From 8ed79c4d38f65b971bacec8d9b78c802490cc19e Mon Sep 17 00:00:00 2001
From: andybeet <22455149+andybeet@users.noreply.github.com>
Date: Fri, 17 Jan 2025 14:41:25 -0500
Subject: [PATCH] add short term trend to plot_chl_pp (monthly figure )

---
 R/plot_chl_pp.R    | 11 +++++++----
 man/plot_chl_pp.Rd |  5 ++++-
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/R/plot_chl_pp.R b/R/plot_chl_pp.R
index e0c93262..6ee1fb7d 100644
--- a/R/plot_chl_pp.R
+++ b/R/plot_chl_pp.R
@@ -9,6 +9,7 @@
 #' @param plottype Character string. Which plot ("weekly", "monthly", "anomaly")
 #' Weekly and monthly plots are for both variables, annual anomaly plot for PP only.
 #' @param year Numeric value. Optional. Year for weekly plot, defaults to max year in data.
+#' @param n Numeric scalar. Number of years used (from most recent year) to estimate short term trend . Default = 0 (No trend calculated)
 #'
 #' @return ggplot object
 #'
@@ -20,7 +21,8 @@ plot_chl_pp <- function(shadedRegion = NULL,
                         report="MidAtlantic",
                         varName="chl",
                         plottype="weekly",
-                        year=NULL) {
+                        year=NULL,
+                        n= 0) {
 
   # generate plot setup list (same for all plot functions)
   setup <- ecodata::plot_setup(shadedRegion = shadedRegion,
@@ -131,10 +133,11 @@ plot_chl_pp <- function(shadedRegion = NULL,
   #
   if(plottype == "monthly") {
     p <- out |>
-      ggplot2::ggplot() +
+      ggplot2::ggplot(ggplot2::aes(x = Year, y = Value, group = Month)) +
       #ecodata::geom_lm(aes(x = Year, y = Value, group = Month))+
-      ggplot2::geom_point(ggplot2::aes(x = Year, y = Value, group = Month)) +
-      ggplot2::geom_line(ggplot2::aes(x = Year, y = Value, group = Month)) +
+      ggplot2::geom_point() +
+      ggplot2::geom_line() +
+      ecodata::geom_lm(n=n) +
       ggplot2::scale_x_discrete(name = "", breaks = seq(min(out$Year),max(out$Year),10)) +
       ggplot2::facet_wrap(EPU~Month~., ncol = 12) +
       ggplot2::ggtitle(paste0("Monthly median ",varabbr)) +
diff --git a/man/plot_chl_pp.Rd b/man/plot_chl_pp.Rd
index 478729d0..cfb19e42 100644
--- a/man/plot_chl_pp.Rd
+++ b/man/plot_chl_pp.Rd
@@ -9,7 +9,8 @@ plot_chl_pp(
   report = "MidAtlantic",
   varName = "chl",
   plottype = "weekly",
-  year = NULL
+  year = NULL,
+  n = 0
 )
 }
 \arguments{
@@ -23,6 +24,8 @@ plot_chl_pp(
 Weekly and monthly plots are for both variables, annual anomaly plot for PP only.}
 
 \item{year}{Numeric value. Optional. Year for weekly plot, defaults to max year in data.}
+
+\item{n}{Numeric scalar. Number of years used (from most recent year) to estimate short term trend . Default = 0 (No trend calculated)}
 }
 \value{
 ggplot object