Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

physics update for RRFS.v1 code freeze #785

Conversation

haiqinli
Copy link
Contributor

Description

This PR includes the following updates:
1). MYNN updates;
2). RUC LSM updates (ufs-community/ccpp-physics#163);
3). GF updates for humidity DA; restore scale-awareness in the 1st hour; suppress weak radar reflectivity over water;
4). smoke plume rise updates for stability on WCOSS2.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

  • fixes #<issue_number>
  • fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

How were these changes tested?
-- There changes were tested with standard regression test.

What compilers / HPCs was it tested with?
-- Intel and GNU compilers on Hera.

Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
-- Yes
Have the ufs-weather-model regression test been run? On what platform?

Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
-- Yes, due to the physics updates. (/scratch2/BMC/acomp/Haiqin.Li/stmp4/Haiqin.Li/FV3_RT/rt_261277)

Please commit the regression test log files in your ufs-weather-model branch
-- Yes, will do.

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

  • waiting on noaa-emc/nems/pull/<pr_number>
  • waiting on noaa-emc/fv3atm/pull/<pr_number>

@MatthewPyle-NOAA
Copy link
Collaborator

Am assuming that the pointing at haiqinli's CCPP fork is a temporary item with the merging.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Mar 1, 2024

@haiqinli can you update physics hash ufs-community/ccpp-physics@8a4b102 ?

@grantfirl
Copy link
Collaborator

grantfirl commented Mar 1, 2024

Am assuming that the pointing at haiqinli's CCPP fork is a temporary item with the merging.
@MatthewPyle-NOAA

Yes, the way submodules get merged sequentially, changes that were put in place for testing (like the change to .gitmodules) get reverted alongside updating submodule pointers to the right commit hash of the main or develop branches.

Since this is @haiqinli 's branch, he is responsible for doing this last commit.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Mar 1, 2024

@MatthewPyle-NOAA I updated. This pr is ready to merge. You can go ahead to merge with cleaning up some commit messages. Or I will merge. And then I will follow on ufs-community/ufs-weather-model#2147

@jkbk2004 jkbk2004 requested a review from DusanJovic-NOAA March 1, 2024 15:42
@MatthewPyle-NOAA MatthewPyle-NOAA merged commit d625cd2 into NOAA-EMC:production/RRFS.v1 Mar 1, 2024
@haiqinli haiqinli deleted the production/RRFS.v1-codefreeze branch March 5, 2024 03:35
jkbk2004 pushed a commit that referenced this pull request Oct 18, 2024
* Identical to #785, but it is directed at moving the changes from production/RRFS.v1 to the develop branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants