Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For container build, revert 4 scripts once spack-stack is upgraded to 1.8.0 #88

Open
DavidBurrows-NCO opened this issue Nov 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@DavidBurrows-NCO
Copy link
Contributor

DavidBurrows-NCO commented Nov 13, 2024

What is wrong?

When containerized build was added to gfs-utils, spack-stack 1.8.0 was used. For that reason, 4 files will need to be adjusted once gfs-utils upgrades to spack-stack 1.8.0.

  1. replace and consolidate gfsutils_generic.lua with gfsutils_common.lua
  2. remove gfsutils_generic.lua
  3. in src/tave.fd/CMakeLists.txt, update lines 13-20 (if(LINK_W3EMC) to endif())
  4. in src/vint.fd/CMakeLists.txt, update lines 13-20 (if(LINK_W3EMC) to endif())
  5. CMakeLists.txt, remove option(LINK_W3EMC "Link w3emc library" ON)

What should have happened?

NA

What machines are impacted?

All or N/A

Steps to reproduce

NA

Additional information

Refs #87

Do you have a proposed solution?

No response

@DavidBurrows-NCO DavidBurrows-NCO added the bug Something isn't working label Nov 13, 2024
@DavidBurrows-NCO DavidBurrows-NCO changed the title For container build, revert 3 scripts once spack-stack is upgraded to 1.8.0 For container build, revert 4 scripts once spack-stack is upgraded to 1.8.0 Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant