-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Aerosol DA to use JCB and Jedi class #3125
Draft
CoryMartin-NOAA
wants to merge
130
commits into
NOAA-EMC:develop
Choose a base branch
from
CoryMartin-NOAA:feature/aero-jcb
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Switch Aerosol DA to use JCB and Jedi class #3125
CoryMartin-NOAA
wants to merge
130
commits into
NOAA-EMC:develop
from
CoryMartin-NOAA:feature/aero-jcb
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e bias correction files from tarball (NOAA-EMC#2862)
…on files using jedi class (NOAA-EMC#2862)
…ns analysis scripts (NOAA-EMC#2862)
CoryMartin-NOAA
requested review from
ypwang19,
andytangborn,
aerorahul,
WalterKolczynski-NOAA and
DavidNew-NOAA
November 26, 2024 18:55
aerorahul
approved these changes
Nov 26, 2024
DavidNew-NOAA
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switches to using JCB for aerosol DA YAML generation + makes use of the Jedi class refactoring already done by @DavidNew-NOAA for the atmospheric JEDI-based DA.
Resolves #3035
Note this PR is in draft for 2 reasons. 1) Need associated GDASApp PR to be opened and merged first and 2) requires some fix file updates. This will be coordinated with an issue and linked to this PR once @andytangborn is satisfied with a first-attempt at the fix files.
Type of change
Change characteristics
How has this been tested?
Checklist