Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Developer Issue]: Add enum for nll_type #613

Open
4 tasks
Andrea-Havron-NOAA opened this issue May 30, 2024 · 0 comments
Open
4 tasks

[Developer Issue]: Add enum for nll_type #613

Andrea-Havron-NOAA opened this issue May 30, 2024 · 0 comments
Assignees
Labels
kind: feature New feature or request theme: NLL refactor Negative log likelihood
Milestone

Comments

@Andrea-Havron-NOAA
Copy link
Collaborator

Andrea-Havron-NOAA commented May 30, 2024

Issue details

  • Add enum to def.hpp
  • rcpp_interface: link user input string to enum
  • model.hpp: use enum to reference correct nll calls and/or create generic function to sum up jnll components (lines 96-111, 137-158, and 194-210).
  • information.hpp: use enum to reference correct nll calls and collapse setup_priors, setup_random_effects, and setup_data into one function
@Andrea-Havron-NOAA Andrea-Havron-NOAA added status: triage_needed This is not approved for this milestone, do not work on it yet kind: feature New feature or request theme: NLL refactor Negative log likelihood sprint 2 and removed status: triage_needed This is not approved for this milestone, do not work on it yet labels May 30, 2024
@kellijohnson-NOAA kellijohnson-NOAA added this to the 2 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: feature New feature or request theme: NLL refactor Negative log likelihood
Projects
None yet
Development

No branches or pull requests

2 participants