update MOM6, ocean_BGC hashes and model configs, add NWA12.CFC test, and refactor NWA12.COBALT test #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yichengt900
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #19 by updating both MOM6 and ocean_BGC hashes to the most updated dev/cefi branch. This includes several commits that will change the baseline answers if you are using CEFI-regional-MOM6 model configurations:
MOM6:
NOAA-CEFI-Regional-Ocean-Modeling/MOM6@671c85d (answers do change if EPBL_ANSWER_DATE is 20240101 or higher)
NOAA-CEFI-Regional-Ocean-Modeling/MOM6@07bace6 (This only happens if initialize the model with
INIT_LAYERS_FROM_Z_FILE = True.)NOAA-CEFI-Regional-Ocean-Modeling/MOM6@6153d97 (if you are using OBC >0)
NOAA-CEFI-Regional-Ocean-Modeling/MOM6@a23c7d8 (if you are using OBC>0 with generic tracer)
ocean_BGC:
NOAA-CEFI-Regional-Ocean-Modeling/ocean_BGC@d4e20e4 (added felim to diazo iron limitation)
NOAA-CEFI-Regional-Ocean-Modeling/ocean_BGC@c34ec93 (re-tuning ml_aclm_efold)
NOAA-CEFI-Regional-Ocean-Modeling/ocean_BGC@f7ac0b7 (jprod_lithdet update)
NOAA-CEFI-Regional-Ocean-Modeling/ocean_BGC@864b0db (Recalibrate calcite and aragonite detritus flux)
A NWA12.CFC CI test is also added for regional MOM6 re-productivity check across layout as well as restart.
This PR has passed both the 1D test and the NWA12.CFC reproducibility test through the GitHub Actions (GHA) workflow. I also conducted the NWA12.COBALT reproducibility test locally, and it passed as well. Currently, I have disabled the NWA12-COBALT GHA workflow because it takes too long and does not serve a good purpose for CI tests.
CC @charliestock , @andrew-c-ross , @theresa-morrison FYI. I am going to merge this PR today and will update our FRE exampled xmls accordingly.