Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing package entry point #111

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixing package entry point #111

wants to merge 3 commits into from

Conversation

Ciheim
Copy link
Contributor

@Ciheim Ciheim commented Feb 13, 2025

Removes the need to manually set path when creating a catalog.

@Ciheim Ciheim self-assigned this Feb 13, 2025
@Ciheim
Copy link
Contributor Author

Ciheim commented Feb 13, 2025

#102

@Ciheim Ciheim changed the title #102 Fixing package entry point Fixing package entry point Feb 13, 2025
@aradhakrishnanGFDL
Copy link
Collaborator

thanks @Ciheim! How was this tested? Please document it stepwise here with an example. thanks!

@aradhakrishnanGFDL
Copy link
Collaborator

@Ciheim what is the expected behavior?

I did a local install, but didn't see gen_intake_gfdl in my path by default. I am missing something though.

Copy link
Collaborator

@aradhakrishnanGFDL aradhakrishnanGFDL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation of tests in the PR are needed. My tests are not successful. Comments are on the PR for reference.

@Ciheim
Copy link
Contributor Author

Ciheim commented Feb 20, 2025

I'm going to have to go back over this. Seeing different behavior now.

@Ciheim
Copy link
Contributor Author

Ciheim commented Feb 20, 2025

Should be working now. I had to change the method being used by the entry point so that it could understand the CLI arguments.

Test:

conda activate catalogbuilder
pip install . (just to be sure we have the latest changes)
gen_intake_gfdl /archive/am5/am5/am5f3b1r0/c96L65_am5f3b1r0_pdclim1850F/gfdl.ncrc5-deploy-prod-openmp/pp ~/test_cat

gives:
INFO:local:[Mostly] silent log activated
INFO:local:Default schema: catalogbuilder/cats/gfdl_template.json
INFO:local:input path: /archive/am5/am5/am5f3b1r0/c96L65_am5f3b1r0_pdclim1850F/gfdl.ncrc5-deploy-prod-openmp/pp
INFO:local: output path: /home/Ciheim.Brown/test_cat
JSON generated at: /home/Ciheim.Brown/test_cat.json
CSV generated at: /home/Ciheim.Brown/test_cat.csv
INFO:local:CSV generated at/home/Ciheim.Brown/test_cat.csv

@Ciheim
Copy link
Contributor Author

Ciheim commented Feb 20, 2025

@aradhakrishnanGFDL When you have a chance please try it again and let me know how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants