Add a vertically resolved CO2 diagnostic #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
7 tasks
This is also ensures that all 3D diagnostics-manager controlled diagnostics are only registered if gfs_physics_nml.ldiag3d is set to .true..
spencerkclark
force-pushed
the
co2-diagnostic
branch
from
ba6e76e to
6f4bd55
Compare
spencerkclark
commented
Jan 11, 2024
Comment on lines
+3034
to
+3044
| index = index + 1 | ||
| Diag_diag_manager_controlled(index)%axes = 3 | ||
| Diag_diag_manager_controlled(index)%name = 'co2' | ||
| Diag_diag_manager_controlled(index)%desc = 'carbon dioxide concentration' | ||
| Diag_diag_manager_controlled(index)%unit = 'volume mixing ratio' | ||
| Diag_diag_manager_controlled(index)%mod_name = 'gfs_phys' | ||
| Diag_diag_manager_controlled(index)%coarse_graining_method = AREA_WEIGHTED | ||
| allocate (Diag_diag_manager_controlled(index)%data(nblks)) | ||
| do nb = 1,nblks | ||
| Diag_diag_manager_controlled(index)%data(nb)%var3 => IntDiag(nb)%co2(:,:) | ||
| enddo |
There was a problem hiding this comment.
This is the only diagnostic field added; the other changes are related only to indentation.
|
@spencerkclark Could you merge in the main branch? I just merged in a PR that resolves issues with the CI in this repository. |
|
@laurenchilutti nice, sure thing! |
lharris4
approved these changes
Jan 11, 2024
bensonr
approved these changes
Jan 12, 2024
spencerkclark
added a commit
to ai2cm/fv3net
that referenced
this pull request
Jan 23, 2024
This PR bumps SHiELD-wrapper to include the latest SHiELD updates, including a CO2 diagnostic: NOAA-GFDL/SHiELD_physics#39. Coverage reports (updated automatically):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a diagnostic for the carbon dioxide concentration used by the model, which is useful both for reference and debugging purposes.
This PR is also ensures that all 3D diagnostics-manager controlled diagnostics are only registered if
gfs_physics_nml.ldiag3dis set to.true.; this prevents awkward crashes in the case that one requests a 3D physics field, but memory is not allocated for it. Note this requires a PR to theatmos_driversrepository (see NOAA-GFDL/atmos_drivers#33).How Has This Been Tested?
I have tested this at C12 resolution in a short three hour run starting on 2016-08-01. The spatial pattern and global mean vertical profiles (on the order of 400 to 403 parts per million) both look reasonable.
Checklist:
Please check all whether they apply or not