Update parameters used for snow cover fraction scheme #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the parameter values for the MODIS vegetation type dataset in version 4.5 of Noah-MP: https://github.com/NCAR/noahmp/blob/7ee673e88cc7a4351be329d92809a0c1ce027053/parameters/MPTABLE.TBL#L222-L225 See here for the original commit to the Noah-MP repository: NCAR/noahmp@03690c5
lharris4
approved these changes
Jun 17, 2024
|
I think this looks OK. Thanks. |
laurenchilutti
approved these changes
Jun 18, 2024
|
@spencerkclark would you like Kai to review this before we merge? |
|
Thanks @laurenchilutti and @lharris4! Yes, it would be great to get @kaiyuan-cheng's approval before merging—it should hopefully be straightforward to review. |
|
Perfect, thanks @kaiyuan-cheng! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates some parameters used in the snow cover fraction scheme of Noah-MP to be consistent with those in official version 4.5. The commit that added these in the official Noah-MP repository is here.
cc: @kaiyuan-cheng @lharris4
How Has This Been Tested?
I have tested this in a year-long C24 resolution simulation with prescribed observed 2020 sea surface temperature and sea ice and compared the monthly mean surface albedo to ERA5. Quantitatively in terms of land RMSE the differences are marginal, but it does seem to help the albedo bias be less systematically negative.
Before
After
Checklist:
Please check all whether they apply or not