Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose finer grained control over code in update_atmos_radiation_physics? #27

Closed
spencerkclark opened this issue Oct 13, 2023 · 2 comments · Fixed by #30
Closed

Expose finer grained control over code in update_atmos_radiation_physics? #27

spencerkclark opened this issue Oct 13, 2023 · 2 comments · Fixed by #30
Labels
enhancement New feature or request

Comments

@spencerkclark
Copy link
Member

Over the years we have found it useful to be able to split the time loop of FV3GFS into a finer-grained set of steps. In particular for one application we found it necessary to break the update_atmos_radiation_physics subroutine up into three parts:

  • update_atmos_pre_radiation
  • update_atmos_radiation
  • update_atmos_physics

ai2cm/fv3gfs-fortran#317 illustrates how we proceeded with this in FV3GFS. The update_atmos_radiation_physics subroutine is retained and does exactly what it did before (so this does not change answers and requires no downstream code changes), but is written in a more modular fashion, exposing its steps as additional public subroutines in atmos_model_mod. Would we be open to doing the same in SHiELD?

@spencerkclark spencerkclark added the enhancement New feature or request label Oct 13, 2023
@spencerkclark
Copy link
Member Author

ai2cm/SHiELD-wrapper#7 illustrates this working in the SHiELD wrapper. Note it points to a branch on my fork of the NOAA-GFDL/atmos_drivers repository; the relevant code changes in atmos_model.F90 are here. I can open a PR if given the green light.

@spencerkclark
Copy link
Member Author

cc: @lharris4 @bensonr sorry for not tagging you earlier (I now see you are not following this repo). I made a draft PR to make the proposed changes a little more visible: #30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant