Improve ci workflows #127
Merged
Improve ci workflows #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename job to "publish" now reflects scheme of build_conda.yml
fix environment name in python/pytest calls
now reflects meta.yaml
remove specific python version requirement, any python 3.9 or higher is fine. use full path to python interpreter for `pip install` call- call pip as python module to make sure fre-cli is installed in the conda env's python... NOT the python-setup step's python..
remove "noarch: python" field from `meta.yaml` see comment in file
testing adding the build conda environment's bin folder to $GITHUB_PATH. this is how conda is made callable in the pipeline... so maybe this will help the python interpreter link up python-cdo with the cdo installation in the conda env.
add pip as a dependency in environment.yml
ilaflott
added a commit
to NOAA-GFDL/CatalogBuilder
that referenced
this pull request
Jul 24, 2024
implementing conda env tricks for github ci/cd i figured out here: NOAA-GFDL/fre-cli#127
add back in noarch field w/ value `python`. unsure it was ever relevant to `conda env create` anyways.
Ciheim
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
updates
environment.ymlto reflect the same dependencies as whats inmeta.yaml, plus pip.adds workflow file
create_test_conda_env.ymlto useenvironment.ymlto create environment, then uses that environment's python/pip to installfre-cliin that environment, and that environment'spytestis called to run tests.publish_conda.yml's job name is changed to justpublishfrombuild_and_publish, to line up more with the workflow file's name.Issue ticket number and link (if applicable)
#122, #75
Checklist before requesting a review
I wrote a new test, if applicableI wrote new instructions/documentation, if applicableI ran pylint and attempted to implement some of it's feedback