From 8ac97bfb815b99e359addd1deaa60ec49ca75300 Mon Sep 17 00:00:00 2001 From: Ian Date: Fri, 26 Jul 2024 10:48:48 -0400 Subject: [PATCH 1/3] Update create_test_conda_env.yml i want to see if i can get pylint to run as a sep step. update workflow calls to reflect whats in the `conda build` target `meta.yml` --- .github/workflows/create_test_conda_env.yml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/.github/workflows/create_test_conda_env.yml b/.github/workflows/create_test_conda_env.yml index c6c83e44..253d6e27 100644 --- a/.github/workflows/create_test_conda_env.yml +++ b/.github/workflows/create_test_conda_env.yml @@ -35,4 +35,16 @@ jobs: python --version $CONDA/envs/fre-cli/bin/python --version # run pytest - $CONDA/envs/fre-cli/bin/pytest + #$CONDA/envs/fre-cli/bin/pytest + pytest --config-file=fre/pytest.ini --cov-config=fre/coveragerc --cov=fre fre/ + + - name: Run pylint in fre-cli environment + run: | + # try to make sure the right things are in GITHUB_PATH + echo $CONDA/envs/fre-cli/bin >> $GITHUB_PATH + which python + python --version + $CONDA/envs/fre-cli/bin/python --version + # run pytest + #$CONDA/envs/fre-cli/bin/pylint + pylint fre/ || echo "pylint returned non-zero exit code. preventing workflow from dying with this echo." From 5a88208aaf17f22aea8928cfbc92bde50b22385e Mon Sep 17 00:00:00 2001 From: Ian Date: Fri, 26 Jul 2024 11:02:10 -0400 Subject: [PATCH 2/3] Update fre.py pylint feedback --- fre/fre.py | 1 + 1 file changed, 1 insertion(+) diff --git a/fre/fre.py b/fre/fre.py index 2623f8a1..ea2afa6d 100644 --- a/fre/fre.py +++ b/fre/fre.py @@ -34,6 +34,7 @@ ) def fre(): + ''' entry point function to subgroup functions ''' pass if __name__ == '__main__': From 5ff53cec37c48bb1ee3182b5d913f8008577f9c2 Mon Sep 17 00:00:00 2001 From: Ian Date: Tue, 30 Jul 2024 12:08:25 -0400 Subject: [PATCH 3/3] Update create_test_conda_env.yml quick clean up edit --- .github/workflows/create_test_conda_env.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/create_test_conda_env.yml b/.github/workflows/create_test_conda_env.yml index 253d6e27..e2df48e7 100644 --- a/.github/workflows/create_test_conda_env.yml +++ b/.github/workflows/create_test_conda_env.yml @@ -35,7 +35,6 @@ jobs: python --version $CONDA/envs/fre-cli/bin/python --version # run pytest - #$CONDA/envs/fre-cli/bin/pytest pytest --config-file=fre/pytest.ini --cov-config=fre/coveragerc --cov=fre fre/ - name: Run pylint in fre-cli environment @@ -46,5 +45,4 @@ jobs: python --version $CONDA/envs/fre-cli/bin/python --version # run pytest - #$CONDA/envs/fre-cli/bin/pylint pylint fre/ || echo "pylint returned non-zero exit code. preventing workflow from dying with this echo."