Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add container buildscript creation for createDockerfile #277

Merged
merged 3 commits into from
Nov 27, 2024
Merged

add container buildscript creation for createDockerfile #277

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
879a772
always create a container buildscript for createDockerfile subcommand
Nov 26, 2024
5b24ee9
Merge branch 'NOAA-GFDL:main' into createDockerfile-buildscript
rem1776 Nov 27, 2024
999e459
add import to createDockerfile.py
Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions fre/make/createDocker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,13 @@ def dockerfile_create(yamlfile,platform,target,execute):
click.echo("\ntmpDir created in " + currDir + "/tmp")
click.echo("Dockerfile created in " + currDir +"\n")

if run:
dockerBuild.build(containerBuild, containerRun)
else:
sys.exit()
# create build script for container
dockerBuild.createBuildScript(containerBuild, containerRun)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm ok, I thought this looked ok but for some reason I'm seeing this when testing:

AttributeError: 'container' object has no attribute 'createBuildScript'

Copy link
Collaborator

@singhd789 singhd789 Nov 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAIT, I think I just forgot to install the recent changes in my conda environment

print("Container build script created at "+dockerBuild.userScriptPath+"\n\n")

# run the script if option is given
if run:
subprocess.run(args=[dockerBuild.userScriptPath], check=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to import subprocess on the top!


@click.command()
def _dockerfile_create(yamlfile,platform,target,execute):
Expand Down