-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port functionality for reading observations from local files #111
Comments
A few designs and design considerations: For observation plugins to provide an appropriate time series for evaluation, we likely will need to provide the following as parameters:
Aside, calibrating non-streamflow values is not out of the question. Whatever interface we decide on should support that use case IMO. def ngen_cal_model_observations(
id: str | None,
start_time: datetime,
end_time: datetime,
simulation_interval: pd.Timedelta,
) -> Series:
|
Now that #155 has been merged, while we don't directly implement this feature, there is nothing stopping someone from writing a plugin to do this. This was not explicitly added as a feature that we will maintain b.c. workflows could vary drastically. It feels like the perfect fit for a plugin. |
Similar to #130, apply an observation hook to allow changing the default (hook implemented with eval nexus NWIS feature data loading) behavior which allows reading obs from local files.
Consider how to support plugins and provide user configurability for "supported plugins" and externally provided/registered plugins.
The text was updated successfully, but these errors were encountered: