Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cfe init config #133

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Jun 24, 2024

Update cfe init config model so that it is compliant with the changes introduced in NOAA-OWP/cfe#116. Don't merge until NOAA-OWP/cfe#116 has been merged.

@aaraney aaraney requested a review from hellkite500 June 24, 2024 17:09
@hellkite500
Copy link
Member

NOAA-OWP/cfe#116 was closed without merging -- do we need to track a different integration for this effort?

@hellkite500 hellkite500 marked this pull request as draft June 27, 2024 04:29
@aaraney
Copy link
Member Author

aaraney commented Jul 2, 2024

Thanks for doing some link chasing, @hellkite500! It looks like NOAA-OWP/cfe#120 took the place of NOAA-OWP/cfe#116 and has already been merged.

@ajkhattak
Copy link

@hellkite500 @aaraney you guys are right. NOAA-OWP/cfe#116 was not merged but all the changes were incorporated into NOAA-OWP/cfe#120 (thanks Austin for linking it with CFE#116). Another PR NOAA-OWP/cfe#121 is also expected to be merged this week, and that would be the official CFE2.0, hopefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants