Update cfe, topmodel, and lgar calibratable parmeters; ngen.cal python < 3.9 pin fiona<1.10.0
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiona v 1.10.0 deprecated 'fiona.path' field (seem to have been removed?) https://github.com/Toblerity/Fiona/releases/tag/1.10.0 geopandas geojson reader uses fiona. geopandas v0.14 dropped support for python<3.9. so, ngen.cal installations are effectively pinned to geopandas <= v0.14. transitively, ngen.cal needs to pin fiona<1.10.0 for compatibility. https://geopandas.org/en/stable/docs/changelog.html#version-0-14-sep-15-2023
aaraney
added
enhancement
aaraney
requested review from
hellkite500
and removed request for
robertbartel
hellkite500
reviewed
Sep 6, 2024
aaraney
changed the title
cfe, topmodel, and lgar calibratable parmeterscfe, topmodel, and lgar calibratable parmeters; ngen.cal python < 3.9 pin fiona<1.10.0
Co-authored-by: Nels <[email protected]>
aaraney
force-pushed
the
update-calibration-params
branch
from
b824e09 to
f10f552
Compare
hellkite500
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ngen.configAdditions
LgarParamsCfeParams,TopmodelParams, andLgarParamsparametersCfeParamsandTopmodelParamscalibratable parametersRemovals
CfeParamsbbandmultiplierfields dropped.bbis nowb; support formultiplierwas dropped in Fix bug with calibratable parameters and add new parameters cfe#64ngen.calChanges
ngen.calonpython3.9pinsfiona<1.10.0(see notes)Notes:
fionav1.10.0deprecatedfiona.pathfield (seem to have been removed?) see.geopandasgeojsonreader usesfiona.geopandasv0.14dropped support forpython<3.9. So,ngen.calinstallations are effectively pinned togeopandas<=0.14. Transitively,ngen.calneeds to pinfiona<1.10.0for compatibility.https://geopandas.org/en/stable/docs/changelog.html#version-0-14-sep-15-2023