Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update objectives.py so uses kge instead of 1-kge #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ben-Choat
Copy link
Contributor

I think as an artifact of previous times when all optimization was done via minimization, if a user wanted to optimize using 'kling_gupta', they would have to specify 'min' as target. This is completely counterintuitive since kge should be maxmized (-inf<kge<=1 and kge=1 is best possible score). By using kge direclty, the user can intuitively set the target as 'max'.

[Short description explaining the high-level reason for the pull request]

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Linux
  • MacOS

I think as an artifact of previous times when all optimization was done via minimization, if a user wanted to optimize using 'kling_gupta', they would have to specify 'min' as target. This is completely counterintuitive since kge should be maxmized (-inf<kge<=1 and kge=1 is best possible score). By using kge direclty, the user can intuitively set the target as 'max'.
@hellkite500
Copy link
Member

I think this is something we need to do, but I would like to keep the ability to effectively "minimize" kge using this technique. Perhaps a new function with a distinct name which inverts the KGE range would be best. Then kge could be used as the original kling_gupta_efficiency without the need of a wrapper function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants