Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a missing "std::" in NGen.cpp for make_unique pointer involving r… #636

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

stcui007
Copy link
Contributor

A missing "std::" in NGen.cpp in one line of code involving "make_unique" pointer for routing causes a build error when "Ngen_Active_Routing" is set active. This PR fix that

[Short description explaining the high-level reason for the pull request]

Additions

Removals

Changes

Add the "std::" in front of "make_unique<routing_py_adapter::Routing_Py_Adapter>" fix the issue.

Testing

Run ngen with routing active.

Screenshots

Notes

Todos

Checklist

  • [x ] PR has an informative and human-readable title
  • [x ] Changes are limited to a single goal (no scope creep)
  • [x ] Code can be automatically merged (no conflicts)
  • [ x] Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • [x ] Any change in functionality is tested
  • [x ] New functions are documented (with a description, list of inputs, and expected output)
  • [x ] Placeholder code is flagged / future todos are captured in comments
  • [x ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • [x ] Linux

@mattw-nws mattw-nws merged commit 944f8fe into master Sep 14, 2023
18 of 19 checks passed
@mattw-nws mattw-nws deleted the fix_ngen_std branch September 14, 2023 19:06
@PhilMiller PhilMiller linked an issue Sep 15, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The latest version of NGen.cpp causes a build error on GCC8 (Linux)
2 participants