Netcdf output #744
Netcdf output #744
Conversation
|
Closes #714. |
Added a test for parsing encoded netcdf descriptions.
…ger. Clean up of parsing code. Workaround for ncType being non copiable.
Add first part of netcdf from layer code added NGen.cpp.
extern/test_bmi_py/README.md
Outdated
| @@ -5,6 +5,7 @@ | |||
| - run_bmi_unit_test.py: This is a file that runs each BMI unit test to make sure that the BMI is complete and functioning as expected. | |||
| - config.yml: This is a configuration file that the BMI reads to set inital_time (initial value of current_model_time) and time_step_seconds (time_step_size). | |||
| - environment.yml: Environment file with the required Python libraries needed to run the model with BMI. Create the environment with this command: `conda env create -f environment.yml`, then activate it with `conda activate bmi_test` | |||
| - requirments.txt: This file is used to install needed packages into system or venv directories using the command 'pip install -r requirements.txt' | |||
There was a problem hiding this comment.
| - requirments.txt: This file is used to install needed packages into system or venv directories using the command 'pip install -r requirements.txt' | |
| - requirements.txt: This file is used to install needed packages into system or venv directories using the command 'pip install -r requirements.txt' |
Netcdf output.
by querying the formulations present in each layer
…keep one signature.
include/core/Layer.hpp
Outdated
| /** | ||
| * @brief Get a list of output variables names for this layer | ||
| * | ||
| * @return vector of output variable names | ||
| */ | ||
|
|
There was a problem hiding this comment.
Did you __ a function here?
There was a problem hiding this comment.
I think that was a function that was removed as redundant.
There was a problem hiding this comment.
The actual information comes from the BMI realizations of the contained models, it would be nice for the layer to have a summary but currently it is not needed to get things to work. This could be used to limit what variables are output.
|
It looks like there's a signature mismatch between There's also some efficiency tradeoffs on offer between the simplicity of making the |
|
The information in any one bmi model can not be written to netcdf efficiently. The code for doing this could be move to a different method but it needs to happen. We need to write to each netcdf variable once a time step, not 20,000 times in the case of CONUS. |
This pull request adds classes for support of netcdf output and initial tests of the writer code.
Additions
Netcdf writer class
Netcdf writer tests
Removals
None
Changes
None
Testing
Screenshots
Notes
Todos
Add model framework integration.
Checklist
Testing checklist (automated report can be put here)
Target Environment support