From 7590ef316a5b3b5a9652dedaf01666dee56f0863 Mon Sep 17 00:00:00 2001 From: Pietro Monticone <38562595+pitmonticone@users.noreply.github.com> Date: Fri, 13 Oct 2023 16:03:57 +0200 Subject: [PATCH 01/11] Update adding_new_problem_model.md --- docs/src/tutorials/adding_new_problem_model.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/tutorials/adding_new_problem_model.md b/docs/src/tutorials/adding_new_problem_model.md index ab81f6ed04..bc41792a29 100644 --- a/docs/src/tutorials/adding_new_problem_model.md +++ b/docs/src/tutorials/adding_new_problem_model.md @@ -36,7 +36,7 @@ It is possible to define a Custom Decision Problem that gives the user full cont struct MyCustomDecisionProblem <: PSI.DecisionProblem end ``` -Alternatevely, it is possible to define a Custom Decision Problem subtyping from `DefaultDecisionProblem` which imposes more requirements and structure onto the developer but employs more checks and validations in the process. Be aware that this route will decrease the flexibility of what can be done inside the custom model. +Alternatively, it is possible to define a Custom Decision Problem subtyping from `DefaultDecisionProblem` which imposes more requirements and structure onto the developer but employs more checks and validations in the process. Be aware that this route will decrease the flexibility of what can be done inside the custom model. ```julia struct MyCustomDecisionProblem <: PSI.DefaultDecisionProblem end From 4171ab1ee4fff0f675096b65a7ff0a46f3b08bcd Mon Sep 17 00:00:00 2001 From: Pietro Monticone <38562595+pitmonticone@users.noreply.github.com> Date: Fri, 13 Oct 2023 16:04:00 +0200 Subject: [PATCH 02/11] Update quick_start_guide.md --- docs/src/quick_start_guide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/quick_start_guide.md b/docs/src/quick_start_guide.md index 040efe87db..20056949e6 100644 --- a/docs/src/quick_start_guide.md +++ b/docs/src/quick_start_guide.md @@ -1,6 +1,6 @@ # Quick Start Guide -* **Julia:** If this is your first time using Julia visit our [Introduction to Julia](https://nrel-Sienna.github.io/SIIP-Tutorial/fundamentals/introduction-to-julia/) and the official[Getting started with Julia](https://julialang.org/learning/). +* **Julia:** If this is your first time using Julia visit our [Introduction to Julia](https://nrel-Sienna.github.io/SIIP-Tutorial/fundamentals/introduction-to-julia/) and the official [Getting started with Julia](https://julialang.org/learning/). * **Package Installation:** If you want to install packages check the [Package Manager](https://pkgdocs.julialang.org/v1/environments/) instructions, or you can refer to the [PowerSimulations installation instructions](@ref Installation). * **PowerSystems:** [PowerSystems.jl](https://github.com/nrel-Sienna/PowerSystems.jl) manages the data and is a fundamental dependency of PowerSimulations.jl. Check the [PowerSystems.jl Basics Tutorial](https://nrel-sienna.github.io/PowerSystems.jl/stable/tutorials/basics/) and [PowerSystems.jl documentation](https://nrel-Sienna.github.io/PowerSystems.jl/stable/) to understand how the inputs to the models are organized. * **Dataset Library:** If you don't have a data set to start using `PowerSimulations.jl` check the test systems provided in [`PowerSystemCaseBuilder.jl`](https://nrel-sienna.github.io/PowerSystems.jl/stable/tutorials/powersystembuilder/) From 9e46190047378d8b186f9b7837b2ca38a9f5e9cd Mon Sep 17 00:00:00 2001 From: Pietro Monticone <38562595+pitmonticone@users.noreply.github.com> Date: Fri, 13 Oct 2023 16:04:04 +0200 Subject: [PATCH 03/11] Update debugging_infeasible_models.md --- docs/src/modeler_guide/debugging_infeasible_models.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/modeler_guide/debugging_infeasible_models.md b/docs/src/modeler_guide/debugging_infeasible_models.md index aa38a2f255..c96c7ff78b 100644 --- a/docs/src/modeler_guide/debugging_infeasible_models.md +++ b/docs/src/modeler_guide/debugging_infeasible_models.md @@ -1,6 +1,6 @@ # Debugging infeasible models -Getting infeasible solutions to models is a common ocurrence in operations simulations, there are multiple reasons why this can happen. +Getting infeasible solutions to models is a common occurrence in operations simulations, there are multiple reasons why this can happen. `PowerSimulations.jl` has several tools to help debug this situation. ## Adding slacks to the model From b91cbcd4e5385329d7fb46387109bf418297fb02 Mon Sep 17 00:00:00 2001 From: Pietro Monticone <38562595+pitmonticone@users.noreply.github.com> Date: Fri, 13 Oct 2023 16:06:14 +0200 Subject: [PATCH 04/11] Update README.md --- docs/src/formulation_library/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/src/formulation_library/README.md b/docs/src/formulation_library/README.md index 5297dd5896..ce4233c407 100644 --- a/docs/src/formulation_library/README.md +++ b/docs/src/formulation_library/README.md @@ -5,7 +5,7 @@ Formulation documentation should *roughly* follow the template established by Re ## Auto generated items - Valid DeviceModel table: just change the device category in the filter function -- Time Series Parameters: just change the device category and formulation in the `get_defualt_time_series_names` method call +- Time Series Parameters: just change the device category and formulation in the `get_default_time_series_names` method call ## Linked items @@ -13,4 +13,4 @@ Formulation documentation should *roughly* follow the template established by Re - Formulations in the Valid DeviceModel table must have a docstring in src/core/formulations.jl - The Formulation in the @docs block must have a docstring in src/core/formulations.jl - The Variables must have docstrings in src/core/variables.jl -- The Time Series Paraemters must have docstrings in src/core/paramters.jl +- The Time Series Parameters must have docstrings in src/core/parameters.jl From 5ccf75a9e337bb7231e990ac1aaf260b3b5cb3df Mon Sep 17 00:00:00 2001 From: Pietro Monticone <38562595+pitmonticone@users.noreply.github.com> Date: Fri, 13 Oct 2023 16:08:10 +0200 Subject: [PATCH 05/11] Update definitions.jl --- src/core/definitions.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/definitions.jl b/src/core/definitions.jl index 1900cf773f..0097b123a2 100644 --- a/src/core/definitions.jl +++ b/src/core/definitions.jl @@ -46,7 +46,7 @@ const MAX_START_STAGES = 3 const OBJECTIVE_FUNCTION_POSITIVE = 1.0 const OBJECTIVE_FUNCTION_NEGATIVE = -1.0 const INITIALIZATION_PROBLEM_HORIZON = 3 -# The DEFAULT_RESERVE_COST value is used to avoid degeneracy of the solutions, reseve cost isn't provided. +# The DEFAULT_RESERVE_COST value is used to avoid degeneracy of the solutions, reserve cost isn't provided. const DEFAULT_RESERVE_COST = 1.0 const KiB = 1024 const MiB = KiB * KiB From c50eca2a015dcc659e87c8eaa42486da4f6b4225 Mon Sep 17 00:00:00 2001 From: Pietro Monticone <38562595+pitmonticone@users.noreply.github.com> Date: Fri, 13 Oct 2023 16:08:12 +0200 Subject: [PATCH 06/11] Update formulations.jl --- src/core/formulations.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/formulations.jl b/src/core/formulations.jl index 6070734baf..87a6a168c2 100644 --- a/src/core/formulations.jl +++ b/src/core/formulations.jl @@ -21,7 +21,7 @@ Formulation type to enable basic unit commitment representation without any inte """ struct ThermalBasicUnitCommitment <: AbstractStandardUnitCommitment end """ -Formulaiton type to enable standard unit commitment with intertemporal constraints and simplified startup profiles +Formulation type to enable standard unit commitment with intertemporal constraints and simplified startup profiles """ struct ThermalStandardUnitCommitment <: AbstractStandardUnitCommitment end """ @@ -58,7 +58,7 @@ abstract type AbstractLoadFormulation <: AbstractDeviceFormulation end abstract type AbstractControllablePowerLoadFormulation <: AbstractLoadFormulation end """ -Formulation type to add a time series paraemter for non-dispatchable `ElectricLoad` withdrawls to power balance constraints +Formulation type to add a time series parameter for non-dispatchable `ElectricLoad` withdrawls to power balance constraints """ struct StaticPowerLoad <: AbstractLoadFormulation end From 47c9d408832b90da0942b0d176dd669e6553cbeb Mon Sep 17 00:00:00 2001 From: Pietro Monticone <38562595+pitmonticone@users.noreply.github.com> Date: Fri, 13 Oct 2023 16:13:53 +0200 Subject: [PATCH 07/11] Update powermodels_interface.jl --- src/network_models/powermodels_interface.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network_models/powermodels_interface.jl b/src/network_models/powermodels_interface.jl index 009c4369d2..932f2c158f 100644 --- a/src/network_models/powermodels_interface.jl +++ b/src/network_models/powermodels_interface.jl @@ -1,7 +1,7 @@ ################################################################################# # Comments # -# - Ideally the net_injection variables would be bounded. This can be done using an adhoc data model extention +# - Ideally the net_injection variables would be bounded. This can be done using an adhoc data model extension # - the `instantiate_*_expr_model` functions combine `PM.instantiate_model` and the `build_*` methods ################################################################################# # Model Definitions From 1b65aa5d6b8e8e174c1ce7b74986f0af5a72bd01 Mon Sep 17 00:00:00 2001 From: Pietro Monticone <38562595+pitmonticone@users.noreply.github.com> Date: Fri, 13 Oct 2023 16:13:57 +0200 Subject: [PATCH 08/11] Update decision_problems.jl --- src/operation/decision_problems.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/operation/decision_problems.jl b/src/operation/decision_problems.jl index 25592f9d50..4b758c08de 100644 --- a/src/operation/decision_problems.jl +++ b/src/operation/decision_problems.jl @@ -74,7 +74,7 @@ end """ AGCReserveDeployment(system::PSY.System; kwargs...) -Creates a `ProblemTemplate` with default DeviceModels for an AGC Reserve Deplyoment Problem. +Creates a `ProblemTemplate` with default DeviceModels for an AGC Reserve Deployment Problem. Uses the template to create an `DecisionProblem`. # Example From ab7fbfcf66becdd3e6d6e9d0ef6c6474d602146d Mon Sep 17 00:00:00 2001 From: Pietro Monticone <38562595+pitmonticone@users.noreply.github.com> Date: Fri, 13 Oct 2023 16:14:02 +0200 Subject: [PATCH 09/11] Update operation_problem_templates.jl --- src/operation/operation_problem_templates.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/operation/operation_problem_templates.jl b/src/operation/operation_problem_templates.jl index 1eb7e928f4..77338b6132 100644 --- a/src/operation/operation_problem_templates.jl +++ b/src/operation/operation_problem_templates.jl @@ -96,7 +96,7 @@ end """ template_agc_reserve_deployment(; kwargs...) -Creates a `ProblemTemplate` with default DeviceModels for an AGC Reserve Deplyment Problem. This model doesn't support customization +Creates a `ProblemTemplate` with default DeviceModels for an AGC Reserve Deployment Problem. This model doesn't support customization # Example From e4522fd913288a07b4b1271d2da18a914d514b01 Mon Sep 17 00:00:00 2001 From: Pietro Monticone <38562595+pitmonticone@users.noreply.github.com> Date: Fri, 13 Oct 2023 16:14:05 +0200 Subject: [PATCH 10/11] Update agc.jl --- src/services_models/agc.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/services_models/agc.jl b/src/services_models/agc.jl index 96a47b2590..435a4e39d8 100644 --- a/src/services_models/agc.jl +++ b/src/services_models/agc.jl @@ -138,7 +138,7 @@ function add_constraints!( IS.@assert_op frequency_response >= 0.0 # This value is the one updated later in simulation based on the UC result - inv_frequency_reponse = 1 / frequency_response + inv_frequency_response = 1 / frequency_response area_balance = get_variable(container, ActivePowerVariable(), PSY.Area) frequency = get_variable(container, SteadyStateFrequencyDeviation(), U) @@ -163,7 +163,7 @@ function add_constraints!( end const_container[t] = JuMP.@constraint( container.JuMPmodel, - frequency[t] == -inv_frequency_reponse * system_balance + frequency[t] == -inv_frequency_response * system_balance ) end return From 9cf92cd5859a9bbec9e6faf6869afd99b4e6b722 Mon Sep 17 00:00:00 2001 From: Pietro Monticone <38562595+pitmonticone@users.noreply.github.com> Date: Fri, 13 Oct 2023 16:14:09 +0200 Subject: [PATCH 11/11] Update reserve_group.jl --- src/services_models/reserve_group.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/services_models/reserve_group.jl b/src/services_models/reserve_group.jl index 83cf3884b1..a893426c51 100644 --- a/src/services_models/reserve_group.jl +++ b/src/services_models/reserve_group.jl @@ -31,7 +31,7 @@ end ################################## Reserve Requirement Constraint ########################## """ -This function creates the requirement constraint that will be attained by the apropriate services +This function creates the requirement constraint that will be attained by the appropriate services """ function add_constraints!( container::OptimizationContainer,