Jd/hvdc model #1003
Merged
Jd/hvdc model #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulations.jl into jd/hvdc_model
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
daniel-thom
reviewed
Sep 8, 2023
| @@ -27,6 +27,7 @@ const JuMPVariableMatrix = DenseAxisArray{ | |||
| const JuMPFloatArray = DenseAxisArray{Float64} | |||
| const JuMPVariableArray = DenseAxisArray{JuMP.VariableRef} | |||
|
|
|||
| const TwoTerminalHVDCTypes = Union{PSY.TwoTerminalHVDCLine, PSY.TwoTerminalVSCDCLine} | |||
There was a problem hiding this comment.
Should this be an abstract type?
There was a problem hiding this comment.
I don't think there is much value in an additional abstraction in PSY for this.
| devices = | ||
| get_available_components(T, sys, get_attribute(model, "filter_function")) | ||
| add_constraints!(container, FlowRateConstraint, devices, model, network_model) | ||
| add_constraint_dual!(container, sys, model) | ||
| return | ||
| end | ||
|
|
||
| # Repeated method to avoid ambiguity between HVDCP2PUnbounded and HVDCP2PLossless | ||
| # Repeated method to avoid ambiguity between HVDCTwoTerminalUnbounded and HVDCTwoTerminalLossless |
There was a problem hiding this comment.
Would it be worth refactoring to make each duplicate function call a common function such that no logic is duplicated?
There was a problem hiding this comment.
It would still cause the same issue because the arguments will still be ambiguous
src/feedforward/feedforwards.jl
Outdated
| @@ -26,7 +26,7 @@ function attach_feedforward!( | |||
| ff_ = T(; | |||
| component_type = get_component_type(ff), | |||
| source = get_entry_type(get_optimization_container_key(ff)), | |||
| affected_values = [get_entry_type(get_optimization_container_key(ff))], | |||
| affected_values = affected_values = get_entry_type.(get_affected_values(ff)), | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| affected_values = affected_values = get_entry_type.(get_affected_values(ff)), | |
| affected_values = affected_values = | |
| get_entry_type.(get_affected_values(ff)), |
daniel-thom
approved these changes
Sep 13, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #926
closes #917