Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jd/parameter update fixes #1013

Merged
merged 125 commits into from
Nov 21, 2023
Merged

Jd/parameter update fixes #1013

merged 125 commits into from
Nov 21, 2023

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Sep 29, 2023

This is a preliminary PR that enables 3 Dimensional DenseAxisArrays.

@daniel-thom there is a lot happening here. I think that going over the changes in detail is beneficial to make sure nothing is terribly implemented. There were some rush choices that you might want to have a say about them.

@jd-lara jd-lara requested a review from daniel-thom September 29, 2023 02:42
@jd-lara jd-lara self-assigned this Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #1013 (ffd6238) into main (99be324) will decrease coverage by 0.11%.
Report is 40 commits behind head on main.
The diff coverage is 56.75%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1013      +/-   ##
==========================================
- Coverage   79.94%   79.84%   -0.11%     
==========================================
  Files         116      116              
  Lines       12338    12399      +61     
==========================================
+ Hits         9864     9900      +36     
- Misses       2474     2499      +25     
Flag Coverage Δ
unittests 79.84% <56.75%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/PowerSimulations.jl 37.50% <ø> (ø)
src/core/definitions.jl 68.75% <ø> (ø)
src/core/formulations.jl 100.00% <ø> (ø)
src/core/parameters.jl 76.14% <ø> (+1.37%) ⬆️
...els/device_constructors/constructor_validations.jl 100.00% <ø> (ø)
...els/device_constructors/hvdcsystems_constructor.jl 100.00% <100.00%> (ø)
...ces_models/device_constructors/load_constructor.jl 100.00% <100.00%> (ø)
...ce_constructors/renewablegeneration_constructor.jl 92.72% <100.00%> (ø)
src/feedforward/feedforwards.jl 77.64% <ø> (+7.83%) ⬆️
src/network_models/powermodels_interface.jl 87.02% <ø> (ø)
... and 26 more

... and 13 files with indirect coverage changes

@jd-lara jd-lara merged commit a2acb41 into main Nov 21, 2023
8 of 9 checks passed
@jd-lara jd-lara deleted the jd/parameter_update_fixes branch November 21, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants