Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imports to fix bug 1125, test that #1127

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Add imports to fix bug 1125, test that #1127

merged 1 commit into from
Jul 24, 2024

Conversation

GabrielKS
Copy link
Contributor

Fixes #1125 by adding some imports. At some point we should do this more holistically; see NREL-Sienna/InfrastructureSystems.jl#388.

@GabrielKS GabrielKS self-assigned this Jul 24, 2024
@GabrielKS GabrielKS requested a review from jd-lara July 24, 2024 17:51
Copy link
Member

@jd-lara jd-lara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing from my phone but overall looks good. As soon as the tests pass we can merge.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.44%. Comparing base (b405b10) to head (67f4e7e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1127   +/-   ##
=======================================
  Coverage   77.44%   77.44%           
=======================================
  Files         118      118           
  Lines       12658    12658           
=======================================
  Hits         9803     9803           
  Misses       2855     2855           
Flag Coverage Δ
unittests 77.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/PowerSimulations.jl 100.00% <ø> (ø)

Copy link
Contributor

Performance Results

Version Precompile Time
Main 3.186618025
This Branch 3.220315846
Version Build Time
Main-Build Time Precompile 51.13247446
Main-Build Time Postcompile 1.121474616
This Branch-Build Time Precompile 51.041811944
This Branch-Build Time Postcompile 1.201819434
Version Solve Time
Main-Solve Time Precompile 414.50910832
Main-Solve Time Postcompile 393.107716175
This Branch-Solve Time Precompile 456.991508359
This Branch-Solve Time Postcompile 435.638088945

@jd-lara jd-lara merged commit 52d4ca8 into main Jul 24, 2024
9 checks passed
@jd-lara jd-lara deleted the gks/quick_fix_1125 branch October 4, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_resolution not implemented for OptimizationProblemResults
2 participants