Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fix for PowerSimulations #1064 #1078

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Support fix for PowerSimulations #1064 #1078

merged 2 commits into from
Mar 18, 2024

Conversation

GabrielKS
Copy link
Collaborator

Add a getter function to support the fix for NREL-Sienna/PowerSimulations.jl#1064, test it.

src/models/components.jl Outdated Show resolved Hide resolved
@GabrielKS GabrielKS self-assigned this Mar 18, 2024
@GabrielKS GabrielKS requested a review from jd-lara March 18, 2024 21:32
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.25%. Comparing base (770d12c) to head (290a872).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1078   +/-   ##
=======================================
  Coverage   85.24%   85.25%           
=======================================
  Files         170      170           
  Lines        7701     7696    -5     
=======================================
- Hits         6565     6561    -4     
+ Misses       1136     1135    -1     
Flag Coverage Δ
unittests 85.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/models/components.jl 66.10% <100.00%> (+0.58%) ⬆️

... and 5 files with indirect coverage changes

@jd-lara jd-lara merged commit eebe7d3 into main Mar 18, 2024
11 checks passed
@jd-lara jd-lara deleted the gks/fix_psi_1064 branch June 4, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants