Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System constructor keyword argument load_zone_formatter is ignored #1160

Closed
GabrielKS opened this issue Jul 25, 2024 · 3 comments · Fixed by #1192
Closed

System constructor keyword argument load_zone_formatter is ignored #1160

GabrielKS opened this issue Jul 25, 2024 · 3 comments · Fixed by #1192

Comments

@GabrielKS
Copy link
Collaborator

There is a kwarg load_zone_formatter listed as one of the supported SYSTEM_KWARGS:

:load_zone_formatter,

but, unlike all the other SYSTEM_KWARGS, nothing is ever done with it. This is the only reference to it in the codebase. I'm currently in a situation where I need to remap the names of load zones, so it would be nice to support this behavior as we do for buses, generators, branches, etc.

@GabrielKS
Copy link
Collaborator Author

good first issue because if all we need is a name formatter I think it could be implemented pretty similarly to the existing ones

@rodrigomha
Copy link
Contributor

rodrigomha commented Sep 12, 2024

@GabrielKS What do you need to do here? The main problem is that powerworld does not create a zone dictionary. The load zones are created manually based on the information in the bus dictionary in bus["zone"] key. Would be tricky to pass a function is that we don't have access at the moment of creation of any additional data x that we can do something.

@GabrielKS
Copy link
Collaborator Author

@rodrigomha my use case is here — I am creating a System from a PSS/E .raw file and adjusting a bunch of names based on a JSON that gets written alongside the .raw by the new Sienna PSS/E exporter. All I need is the ability to pass in a mapping from what Sienna thinks the name should be to what I actually want the name to be and have that be evaluated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants