Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update asset directory for picture links #1170

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

kdayday
Copy link
Contributor

@kdayday kdayday commented Aug 5, 2024

This breaks the docs pictures for my local build, but matches Rodrigo's suggestions and the previous format.

@kdayday kdayday requested review from jd-lara and rodrigomha August 5, 2024 19:40
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.51%. Comparing base (0c9c8b3) to head (e94c87f).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1170      +/-   ##
==========================================
- Coverage   84.75%   84.51%   -0.24%     
==========================================
  Files         182      179       -3     
  Lines        8349     8165     -184     
==========================================
- Hits         7076     6901     -175     
+ Misses       1273     1264       -9     
Flag Coverage Δ
unittests 84.51% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rodrigomha rodrigomha changed the base branch from main to kd/broken_pics_temp August 5, 2024 19:51
Copy link
Contributor

@rodrigomha rodrigomha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temp merge

@rodrigomha rodrigomha merged commit ebfc66c into NREL-Sienna:kd/broken_pics_temp Aug 5, 2024
10 checks passed
@kdayday kdayday deleted the broken_pics branch August 17, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants