-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation clean up, update to Documenter 1.0, add *.md to formatter (PSY portion) #1176
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1176 +/- ##
==========================================
- Coverage 84.61% 84.61% -0.01%
==========================================
Files 180 181 +1
Lines 8267 8285 +18
==========================================
+ Hits 6995 7010 +15
- Misses 1272 1275 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rodrigomha who wrote this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably me lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some crazy text there lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything else to change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should mention that the tabular data parser is about to disappear.
Co-authored-by: Rodrigo Henríquez-Auba <[email protected]>
Co-authored-by: Jose Daniel Lara <[email protected]>
Co-authored-by: Jose Daniel Lara <[email protected]>
…ning for tabular parser
@jd-lara I split out the parsing how-to guide into separate topics, including a separate page on the tabular data parser with a warning at the top. |
I think the two setters I added are covered by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this PR to be merged
makedocs
Successful compilation with documenter 1.0 depends on docstring updates in IS NREL-Sienna/InfrastructureSystems.jl#394
Does not include moving the model library into API
Closes #1196