-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adding support for quadratic functions using the table data parser #1178
Conversation
Currently only works for heat rate and not cost curves. Issue #1177
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1178 +/- ##
==========================================
+ Coverage 84.52% 84.55% +0.02%
==========================================
Files 179 179
Lines 8169 8188 +19
==========================================
+ Hits 6905 6923 +18
- Misses 1264 1265 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove or update the warnings and update briefly the docs
This has been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good aside from the typo
Co-authored-by: Gabriel Konar-Steenberg <[email protected]>
Currently only works for heat rate and not cost curves.
Implementation details:
heat_rate_a0
,heat_rate_a1
,heat_rate_a2
. All of the new fields arenull
by default. Open to suggestions on the nameing,heat_rate_a*
column are defined, then we callcreate_poly_cost
forThermalGen
,create_poly_cost
will returnQuadraticCostCurve
if all the coefficients are passedLinearCurve
ifa1
anda0
is passed,LinearCurve
ifa1
is passed,.a2
is passed buta1
ora0
is nothing,Closes #1177