Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Overhaul of the get_components tutorial. #1201

Closed
wants to merge 0 commits into from

Conversation

annacasavant
Copy link

Overhaul of get_component tutorial.

Copy link
Contributor

@kdayday kdayday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted some formatting things, as well as some of the specific items we've already discussed. I'll give it another review after the story-line edit. Thanks!

Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
docs/make.jl Outdated Show resolved Hide resolved
the system and getting both its components and their data. We will also start checking for
time-series data, which we will explore more in the tutorial on
[Working with Time Series Data](@ref tutorial_time_series).
PowerSystems provides functional interfaces to all data. In this tutorial we will explore how to manipulate various static data sets using the `get_component` and `set_*` functions. By the end of this tutorial you will be able to access the data stored in your system and be able to manipulate it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backticks on PowerSystems and all Sienna names/objects


In [Create and Explore a Power `System`](@ref), we created a basic `System` with nodes, a transmission
line, and a few generators. Let's recreate that system if you don't have it already:
We are going to begin by loading in a test case from the `PowerSystemCaseBuilder`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add hyperlink to PSCB github or documentation


```@repl get_components
#### Accessing types of data stored in our system
If we are interested in seeing a certain data type stored in our system, for example the thermal generators, we can call them using the `get_components` function.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hyperlinks on all function names: [`get_components`](@ref)


The fields within a component can be accessed using the `get_*` functions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the first part of this comment back in at some point, as a warning admonition. See also https://nrel-sienna.github.io/PowerSystems.jl/stable/explanation/system/#dot_access

type (concrete or abstract) and the system and it also accepts filter functions for a more
refined search. The container is optimized for iteration over abstract or concrete component
types as described by the [Type Structure](@ref type_structure). Given the potential size of the return,
`PowerSystems.jl` returns Julia iterators in order to avoid unnecessary memory allocations. -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add this last line back in at some point, in a reflection statement about get_components returning an iterator, as a set-up to using collect

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (ba1a44d) to head (029f26b).
Report is 39 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1201      +/-   ##
==========================================
- Coverage   84.61%   84.37%   -0.24%     
==========================================
  Files         181      181              
  Lines        8285     8382      +97     
==========================================
+ Hits         7010     7072      +62     
- Misses       1275     1310      +35     
Flag Coverage Δ
unittests 84.37% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants