Add 2t line physical model #1205
Open
+316
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1205 +/- ##
==========================================
+ Coverage 84.29% 84.34% +0.04%
==========================================
Files 181 182 +1
Lines 8391 8430 +39
==========================================
+ Hits 7073 7110 +37
- Misses 1318 1320 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@jd-lara this is ready for review |
rodrigomha
changed the title
jd-lara
reviewed
Nov 4, 2024
| #! format: off | ||
|
|
||
| """ | ||
| mutable struct TwoTerminalHVDCDetailedLine <: ACBranch |
There was a problem hiding this comment.
Why not re-use the VSC existing structure?
jd-lara
reviewed
Nov 8, 2024
| @@ -35,6 +35,7 @@ export MonitoredLine | |||
| export DCBranch | |||
| export TwoTerminalHVDCLine | |||
| export TwoTerminalVSCDCLine | |||
There was a problem hiding this comment.
Add a comment that this will be dropped in PSY 5.0 please.
|
This is ready for review @jd-lara |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.