Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/json function trial #4

Merged
merged 17 commits into from
Feb 25, 2025
Merged

Pr/json function trial #4

merged 17 commits into from
Feb 25, 2025

Conversation

prao7
Copy link
Contributor

@prao7 prao7 commented Oct 17, 2024

@pesap Adding for your review the latest schema with the updated tables on how the time series and complex data is handled.

  1. Entities and linkages need review on their assignments in the table. Currently are being used as tools for the reserves, but may want to simplify/remove? So far, time series is connecting to the entity that is created from the autofill trigger, or manual add of entity. Do we want to create an entity for time series and then
  2. Values in attributes now handle json and blobs.

@prao7 prao7 requested a review from pesap October 17, 2024 14:18
@prao7 prao7 self-assigned this Oct 17, 2024
@prao7 prao7 marked this pull request as draft October 17, 2024 14:19
Copy link
Member

@pesap pesap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Lets just clean-up and I can re-review it

dummy_data.sql Outdated
(1, strftime('%s', 'now', 'start of day', '+23 hours'), random() * 100);
--
--
-- .print ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep this queries for testing purposes

schema.sql Outdated
Comment on lines 27 to 28
prime_mover text not null,
fuel_type text not null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need the prime mover table for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have the prime mover table. This is used for the prime mover fk

@pesap pesap marked this pull request as ready for review February 25, 2025 19:34
@pesap pesap merged commit 51ca471 into main Feb 25, 2025
1 check passed
@pesap pesap deleted the pr/json-function-trial branch February 25, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants