From 6986346f28f88e78c9b72c78332b8173ea733192 Mon Sep 17 00:00:00 2001 From: Scott Horowitz Date: Fri, 1 Sep 2023 17:37:56 -0600 Subject: [PATCH] Address OS SDK change, exclude new warnings (for now) --- HPXMLtoOpenStudio/resources/hvac.rb | 2 -- workflow/tests/hpxml_translator_test.rb | 4 ++++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/HPXMLtoOpenStudio/resources/hvac.rb b/HPXMLtoOpenStudio/resources/hvac.rb index 411910f227..7e8f59accb 100644 --- a/HPXMLtoOpenStudio/resources/hvac.rb +++ b/HPXMLtoOpenStudio/resources/hvac.rb @@ -1707,14 +1707,12 @@ def self.create_air_loop_unitary_system(model, obj_name, fan, htg_coil, clg_coil air_loop_unitary.setSupplyFan(fan) air_loop_unitary.setFanPlacement('BlowThrough') air_loop_unitary.setSupplyAirFanOperatingModeSchedule(cycle_fan_sch) - air_loop_unitary.setSupplyAirFlowRateMethodDuringHeatingOperation('SupplyAirFlowRate') if htg_coil.nil? air_loop_unitary.setSupplyAirFlowRateDuringHeatingOperation(0.0) else air_loop_unitary.setHeatingCoil(htg_coil) air_loop_unitary.setSupplyAirFlowRateDuringHeatingOperation(UnitConversions.convert(htg_cfm, 'cfm', 'm^3/s')) end - air_loop_unitary.setSupplyAirFlowRateMethodDuringCoolingOperation('SupplyAirFlowRate') if clg_coil.nil? air_loop_unitary.setSupplyAirFlowRateDuringCoolingOperation(0.0) else diff --git a/workflow/tests/hpxml_translator_test.rb b/workflow/tests/hpxml_translator_test.rb index ab29deb2c6..47857ed91c 100644 --- a/workflow/tests/hpxml_translator_test.rb +++ b/workflow/tests/hpxml_translator_test.rb @@ -563,6 +563,10 @@ def _verify_outputs(rundir, hpxml_path, results, hpxml) next if message.include?('setupIHGOutputs: Output variables=Space Other Equipment') && message.include?('are not available') next if message.include? 'DetailedSkyDiffuseModeling is chosen but not needed as either the shading transmittance for shading devices does not change throughout the year' next if message.include? 'View factors not complete' + # FIXME: Double-check this. May be addressed by https://github.com/NREL/OpenStudio-HPXML/pull/1175? + next if message.include?('The shading transmittance for shading devices may change throughout the year') && message.include?('Choose Shading Calculation Update Frequency Method = Timestep in the ShadowCalculation object to capture all shading impacts') + # FIXME: Double-check this. + next if message.include? 'Multiple speed fan will be appiled to this unit. The speed number is determined by load.' # HPWHs if hpxml.water_heating_systems.select { |wh| wh.water_heater_type == HPXML::WaterHeaterTypeHeatPump }.size > 0