BuildResidentialHPXML: create multiple Building elements
#1457
Conversation
| @@ -367,7 +368,7 @@ def _run_xml(xml, worker_num = nil) | |||
| # Uses 'monthly' to verify timeseries results match annual results via error-checking | |||
| # inside the ReportSimulationOutput measure. | |||
| cli_path = OpenStudio.getOpenStudioCLI | |||
| command = "\"#{cli_path}\" \"#{File.join(File.dirname(__FILE__), '../run_simulation.rb')}\" -x \"#{xml}\" --add-component-loads -o \"#{rundir}\" --debug --monthly ALL" | |||
| command = "\"#{cli_path}\" \"#{File.join(File.dirname(__FILE__), '../run_simulation.rb')}\" -x \"#{xml}\" --add-component-loads -o \"#{rundir}\" --debug --monthly ALL -b ALL" | |||
There was a problem hiding this comment.
The --monthly ALL causes, e.g., base-multiple-buildings.xml to fail.
There was a problem hiding this comment.
Most of the timeseries outputs should work, but I think the airflows outputs don't yet. At some point I'll get around to addressing this. In the meantime it should work if you just specify certain timeseries outputs (like enduses, hotwater, etc.).
…fa_mf_models_unit_multiplier
…fa_mf_models_unit_multiplier
…fa_mf_models_unit_multiplier
This comment was marked as resolved.
This comment was marked as resolved.
…fa_mf_models_unit_multiplier
…eduleFile once for each building unit.
…ithub.com/NREL/OpenStudio-HPXML into build_whole_sfa_mf_models_unit_multiplier # Conflicts: # BuildResidentialHPXML/measure.xml
BuildResidentialScheduleFile/tests/build_residential_schedule_file_test.rb
Show resolved
Hide resolved
…fa_mf_models_unit_multiplier
…fa_mf_models_unit_multiplier
…fa_mf_models_unit_multiplier
…fa_mf_models_unit_multiplier
BuildResidentialHPXML/measure.rb
Outdated
| hpxml.header.xml_type = 'HPXML' | ||
| hpxml.header.xml_generated_by = 'BuildResidentialHPXML' | ||
| hpxml.header.transaction = 'create' | ||
|
|
||
| if args[:schedules_vacancy_period].is_initialized | ||
| begin_month, begin_day, begin_hour, end_month, end_day, end_hour = Schedule.parse_date_time_range(args[:schedules_vacancy_period].get) | ||
| hpxml.header.unavailable_periods.add(column_name: 'Vacancy', begin_month: begin_month, begin_day: begin_day, begin_hour: begin_hour, end_month: end_month, end_day: end_day, end_hour: end_hour, natvent_availability: HPXML::ScheduleUnavailable) | ||
|
|
||
| natvent_availability = HPXML::ScheduleUnavailable |
There was a problem hiding this comment.
Seems like this should be inside the unavailable_period_exists method and not here.
There was a problem hiding this comment.
I'm not sure I understand. It gets passed into the unavailable_period_exists method. For the "Vacancy" instance, it's always set to natvent_availability = HPXML::ScheduleUnavailable. For "Power Outage", it's assigned using an argument.
There was a problem hiding this comment.
So inside the method, set natvent_availability = HPXML::ScheduleUnavailable if natvent_availability.nil??
There was a problem hiding this comment.
Yeah, I guess. We'd then be assigning natvent_availability = HPXML::ScheduleUnavailable twice for the "Vacancy" instance...
…fa_mf_models_unit_multiplier
Pull Request Description
Addresses #1376.
Update
BuildResidentialHPXMLas follows:existing_hpxml_pathargument. If it's assigned, the measure adds a building to the HPXML file.This PR also:
BuildResidentialHPXMLtests for successively calling the measure multiple times.hpxml.rbitems related to interior/exterior shading IDs,base-multiple-buildings.xmlusingBuildResidentialHPXML.base-multiple-buildings-varied-occupancy.xmlChecklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
Schematron validator (EPvalidator.xml) has been updatedtasks.rb)HPXMLtoOpenStudio/testsand/orworkflow/tests/hpxml_translator_test.rb)Documentation has been updatedChangelog has been updatedopenstudio tasks.rb update_measureshas been run