Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardset space volume so we avoid autocalculating it #1477

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Conversation

joseph-robertson
Copy link
Collaborator

Pull Request Description

The Polyhedron is not enclosed in original testing. Trying to add missing colinear points. warning for base-enclosure-garage.xml therefore goes away.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (via tasks.rb)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests and/or workflow/tests/hpxml_translator_test.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@joseph-robertson joseph-robertson self-assigned this Sep 5, 2023
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joseph-robertson. This looks appropriate to me. We have a better idea what the volumes are than OS/E+ (since we don't provide them 3D geometry w/ enclosed spaces to use in their calculation).

@shorowit shorowit marked this pull request as ready for review September 5, 2023 17:55
@shorowit shorowit merged commit fd50873 into os370 Sep 5, 2023
@shorowit shorowit deleted the os370-vol branch September 5, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants