Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geothermal loop & soil properties: updates and fixes #1481

Merged
merged 26 commits into from
Sep 21, 2023
Merged

Geothermal loop & soil properties: updates and fixes #1481

merged 26 commits into from
Sep 21, 2023

Conversation

joseph-robertson
Copy link
Collaborator

@joseph-robertson joseph-robertson commented Sep 11, 2023 •
edited
Loading

Pull Request Description

In response to review/guidance from @shorowit and @mitchute.

image

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (via tasks.rb)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests and/or workflow/tests/hpxml_translator_test.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@joseph-robertson joseph-robertson self-assigned this Sep 11, 2023
joseph-robertson and others added 25 commits September 12, 2023 11:14
@joseph-robertson
Move borefield config arg to the top.
b55a59c
@joseph-robertson
Add a readme for g_functions files.
6cee7f5
@joseph-robertson
Simplify soil type constants.
9319b0d
@joseph-robertson
Delete loop idref on heat pump.
42ef6ac
@joseph-robertson
Simplify code in hpxml defaults.
b5af308
@joseph-robertson
Use grout and pipe type in build measure.
d80694e
@joseph-robertson
Change pipe_size to pipe_diameter.
eb233f1
@joseph-robertson
Move geothermal loop line in epvalidator.
1982a5d
@joseph-robertson
Deprecate old ground conductivity field.
a092aa5
@joseph-robertson
Remove extra line in epvalidator.
37e937c
@joseph-robertson
Check that geothermal loop is connected to heat pump.
6b5f7b7
@joseph-robertson
Add comment where default values come from.
d092b14
@joseph-robertson
Misc cleanup around unit conversions, comments.
d309d85
@joseph-robertson
Update docs and remove temporary sample files.
614b0e9
@joseph-robertson
Rename some sample files and regenerate.
d8c1150
@joseph-robertson
Update bore config argument to default to none.
0ad85a9
@joseph-robertson
Combine grout and pipe type choices into one.
8b61136
@joseph-robertson
Revert geothermal loop default and fix tests.
9ca09f6
@joseph-robertson
Update the docs.
aca6d09
Latest results.
35d3f03
@joseph-robertson
Add new loop config argument, update docs and tests.
e220b45
@joseph-robertson
Updates for soil and moisture type arguments, docs, etc.
339aa35
@joseph-robertson
Update min and max error, test, and docs.
1c822ef
@joseph-robertson
Refactor methods around g function jsons, etc.
7a57f41
@joseph-robertson
Missed a size method.
6304889
@joseph-robertson joseph-robertson marked this pull request as ready for review September 21, 2023 22:01
@joseph-robertson joseph-robertson merged commit 244e086 into geothermal_loop Sep 21, 2023
5 checks passed
@joseph-robertson joseph-robertson deleted the geothermal_loop2 branch September 21, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joseph-robertson joseph-robertson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joseph-robertson