Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document autosizing methodology for e.g. dual-fuel HPs #1486

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Sep 19, 2023

Pull Request Description

Closes #1484. Updated language ("For heat pumps with ..."):

image

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (via tasks.rb)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests and/or workflow/tests/hpxml_translator_test.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit added this to the 1.7.0 milestone Sep 19, 2023
@shorowit shorowit self-assigned this Sep 19, 2023
@shorowit shorowit merged commit c6fe890 into master Sep 25, 2023
5 checks passed
@shorowit shorowit deleted the dfhp_sizing_docs branch September 25, 2023 23:44
@joseph-robertson joseph-robertson mentioned this pull request Oct 3, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Reconsider design loads/temps reported based on HP min compressor temperature?
1 participant