Bugfix for CFIS systems w/ supplemental fan and sub-hourly timesteps #1868
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Discovered a bug with supplemental fan runtime for a CFIS system when using sub-hourly timesteps. It would be awfully complicated to fix the issue given how the CFIS EMS program operates (based on time), so I rewrote the program to be simpler (based on outdoor cfm). Now simulations with sub-hourly timesteps better match simulations with hourly timesteps. CFIS systems run with hourly timesteps or without supplemental fans are unchanged.
base-mechvent-cfis.xml
base-mechvent-cfis-airflow-fraction-zero.xml
base-mechvent-cfis-control-type-timer.xml
base-mechvent-cfis-dse.xml
base-mechvent-cfis-evap-cooler-only-ducted.xml
base-mechvent-cfis-no-additional-runtime.xml
base-mechvent-cfis-no-outdoor-air-control.xml
base-mechvent-cfis-supplemental-fan-exhaust-synchronized.xml
base-mechvent-cfis-supplemental-fan-exhaust.xml
base-mechvent-cfis-supplemental-fan-supply.xml
Note 1: We don't expect perfect agreement but HVAC runtime fractions will differ a small amount between hourly and sub-hourly simulations.
Note 2: All files were run with zero infiltration, zero duct losses, and an unvented clothes dryer to eliminate interactions.
Checklist
Not all may apply:
EPvalidator.xml
) has been updatedopenstudio tasks.rb update_hpxmls
)HPXMLtoOpenStudio/tests/test*.rb
and/orworkflow/tests/test*.rb
)openstudio tasks.rb update_measures
has been run