Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Conan 2.0 #4818

Closed
jmarrec opened this issue Mar 9, 2023 · 8 comments
Closed

Support Conan 2.0 #4818

jmarrec opened this issue Mar 9, 2023 · 8 comments

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented Mar 9, 2023

Issue overview

Conan 2.0 has been officially released and includes a number of API breaking changes. Currently we can't build with conan 2.0

Linked issue (where most of the work will be):

@wnykuang
Copy link
Contributor

Just curious, is it possible? Since the cmake-conan hasn't supported conan 2.0 yet:

https://github.com/conan-io/cmake-conan

I am new to the project and Cmake ecosystem, maybe I am wrong.

@tijcolem
Copy link
Collaborator

Hi @wnykuang! Using 2.0 should be possible but it's broken as of now, so you should install the latest 1.X series which I believe is 1.59 https://pypi.org/project/conan/1.59.0/

@wnykuang
Copy link
Contributor

wnykuang commented Mar 10, 2023

Hi @wnykuang! Using 2.0 should be possible but it's broken as of now, so you should install the latest 1.X series which I believe is 1.59 https://pypi.org/project/conan/1.59.0/

Hi! Glad to hear from you!

Yeah, I built the project with 1.48since the script(I believe it's CMake-Conan or something) indicate.
Just curious whether it's possible to support 2.0 from ourside if CMake-Conan doesn't support it yet.

(They indicate:

Compatibility with Conan 2.0: cmake-conan is not compatible with Conan 2.0 for the moment. Once Conan 2.0 is GA the compatibility between both will be analyzed again. Also, please note that CMakeToolchain is not compatible with cmake-conan. If you need to use it, we would recommend not using cmake-conan but doing a conan install directly.
)

(I spent a while to try to build it with Conan 2.0 and figured out there is version issue)

@jmarrec
Copy link
Collaborator Author

jmarrec commented Mar 10, 2023

This is a very good point.
But this isn't a strong necessity as of now, just rely on conan 1.59, I'm just logging it in an issue for later.
Cmake conan will either catchup or we'll just generate a conanfile.txt and call conan on it to match the preferred 2.0 workflow. For now, let's just focus on releasing OS sdk 3.6 :)

@jmarrec
Copy link
Collaborator Author

jmarrec commented Mar 17, 2023

FYI there's a develop2 branch with experimental support on https://github.com/conan-io/cmake-conan/tree/develop2

@wnykuang
Copy link
Contributor

Interesting! I didn't notice it. Thanks for the heads-up, let me take a look!

@jmarrec
Copy link
Collaborator Author

jmarrec commented Mar 18, 2023

Interesting! I didn't notice it. Thanks for the heads-up, let me take a look!

That was announced just yesterday on twitter by conanio :)

@shorowit
Copy link
Contributor

@jmarrec @kbenne Seems like this was addressed by #5137. Close the issue?

@jmarrec jmarrec closed this as completed Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants