Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bit of broken code in /postprocessing/bokehpivot/reeds2.py #189

Closed
wshobe opened this issue Nov 19, 2024 · 2 comments
Closed

A bit of broken code in /postprocessing/bokehpivot/reeds2.py #189

wshobe opened this issue Nov 19, 2024 · 2 comments

Comments

@wshobe
Copy link
Collaborator

wshobe commented Nov 19, 2024

Description of Issue

Our new instantiation of the ReEDS 2.0 model failed to produce any reports. The reason appears to be the addition of two new lines of code in postprocessing/bokehpivot/reeds2.py. One of these lines has a hardcoded directory in it, causing the generation of output to fail:

water_techs = pd.read_csv('/Users/jcarag/ReEDS/PSH_Updates/ReEDS-2.0/postprocessing/bokehpivot/in/reeds2/tech_ctt_wst.csv')['tech'].tolist()
water_techs = [x.lower() for x in water_techs]

Potential Solutions

If this new water_techs code needs to be outside of the add_cooling_water function, then the first line (above) should probably read:

water_techs = pd.read_csv(this_directory_path + '/in/reeds2/tech_ctt_wst.csv')['tech'].tolist()

@pesap
Copy link
Collaborator

pesap commented Nov 19, 2024

Hi @wshobe ,

Thanks for reporting the bug in the code! We also noticed this on the internal version and we are working on the fix as we speak. We will roll the fix on the next version.

cc @kennedy-mindermann

@kennedy-mindermann
Copy link
Collaborator

kennedy-mindermann commented Nov 19, 2024

I just merged a pull request (#190) into the main branch with a fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants