-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add requests package to setup.py #40
Comments
@asparke2 Can you add a minimal reproducible example? conda create -n test_env python=3.10
conda activate test_env
pip install requests
pip install git+https://github.com/NREL/buildstock-query I was then able to import both buildstock_query and requests. from buildstock_query import BuildStockQuery
import requests # no error |
@rajeee remove the >>> from buildstock_query import BuildStockQuery
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "C:\Users\aparker\Anaconda3\envs\test_env\lib\site-packages\buildstock_query\__init__.py", line 63, in <module>
from buildstock_query.main import BuildStockQuery
File "C:\Users\aparker\Anaconda3\envs\test_env\lib\site-packages\buildstock_query\main.py", line 7, in <module>
from buildstock_query.tools import UpgradesAnalyzer
File "C:\Users\aparker\Anaconda3\envs\test_env\lib\site-packages\buildstock_query\tools\__init__.py", line 1, in <module>
from .upgrades_analyzer import UpgradesAnalyzer
File "C:\Users\aparker\Anaconda3\envs\test_env\lib\site-packages\buildstock_query\tools\upgrades_analyzer.py", line 13, in <module>
from buildstock_query.tools.logic_parser import LogicParser
File "C:\Users\aparker\Anaconda3\envs\test_env\lib\site-packages\buildstock_query\tools\logic_parser.py", line 7, in <module>
from buildstock_query.file_getter import OpenOrDownload
File "C:\Users\aparker\Anaconda3\envs\test_env\lib\site-packages\buildstock_query\file_getter.py", line 1, in <module>
import requests
ModuleNotFoundError: No module named 'requests' Basically what I'm saying is that |
Oh duh! Your Issue title was clear enough. Got confused by the description! |
Issue overview
The
requests
package is not imported by another dependency when pip installing buildstock-query. Unclear poeCurrent Behavior
The library does not work after installing via setup.py because of missing
requests
dependencyExpected Behavior
The library works after installing via setup.py
The text was updated successfully, but these errors were encountered: