Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute the list of .rb files at package generation time and install it in the package folder #48

Open
jmarrec opened this issue Mar 17, 2023 · 1 comment

Comments

@jmarrec
Copy link
Contributor

jmarrec commented Mar 17, 2023

The OpenStudio SDK CMake configure call spends an awful amount of time doing

Searching for ruby modules in '/Users/julien/.conan/data/openstudio_ruby/2.7.2/nrel/testing/package/b0b153961e79d4e95517b97d888ce78a877ec1ef/lib/**/*.rb'

https://github.com/NREL/OpenStudio/blob/c665b9fc52efde300e45b967498e2f7b9fdeb7b6/ruby/engine/CMakeLists.txt#L24-L191

We could save this time by doing it when we generate the package instead of everytime we call CMake.

The same should be done in openstudio-gems.

FYI @tijcolem (I just thought of this)

@jmarrec
Copy link
Contributor Author

jmarrec commented Mar 17, 2023

Actually it's more the actual embed_files call that takes a long time

end search ruby: 20230317 20:10:02
end search ruby: 20230317 20:10:02
start search gems: 20230317 20:10:02
end search gems: 20230317 20:10:04
end actual embbed: 20230317 20:10:24
```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant