Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidal module requires tidal_resource even for time series resource data option #1279

Open
mjprilliman opened this issue Feb 17, 2025 · 0 comments
Assignees
Labels
mhk marine hydrokinetic

Comments

@mjprilliman
Copy link
Collaborator

Describe the bug
-"tidal_resource" variable is required always in mhk_tidal cmod, even if model choice is set to time series data
-Fix memory allocation to account for tidal_resource and time series options
-See #1275

Expected behavior
-tidal_resource only required if tidal_resource_model_choice=1
-Number of rows based on power_curve if resource matrix is not provided (maybe always based on power curve)

Context
Found in PySAM development by @kbrunik

@mjprilliman mjprilliman added the mhk marine hydrokinetic label Feb 17, 2025
@mjprilliman mjprilliman added this to the SAM Spring 2025 Release milestone Feb 17, 2025
@mjprilliman mjprilliman self-assigned this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mhk marine hydrokinetic
Projects
None yet
Development

No branches or pull requests

1 participant