Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small script refactor and formula fix for large strings build. #28

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

pierluigizagaria
Copy link

@pierluigizagaria pierluigizagaria commented Sep 4, 2024

I've did some changes to the project.

  • Removed old 2.x versions as the README states Some older formulas might no longer build on newer versions of Homebrew
  • Added fixed scons 4.7.0 formula so we are sure that everything will work in future.
  • Added the `"PREFIX=#{prefix}" build flag as the official repo does to correctly reference the stubs.
  • Included the strlen build stubs when --with-large-strings is used.
  • Removed the bottles part as no pre-compiled files are provided.

After some debug I found that the strlen stubs from the ufficial repo are required in order to make everything work.
Without the strlen stubs it compiles as normal, but the path does not get modified.

With this fork I was successfull to build an installer in my github actions and get the path modified.

@idleberg
Copy link
Contributor

idleberg commented Sep 4, 2024

Thank you for your contribution. I want to let you know upfront that I won't be able to attend this PR for two more weeks since I'm currently on vacation. Will get back to this asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants