-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ophyd-async devices for DOFs #74
Comments
Definition of done:
If ophyd-async doesn't work out of the box (tests fail) then try to resolve issues. |
So it looks like blop cannot currently support ophyd-async devices as There are a couple of options worth considering here to add ophyd-async support (in order of my personal preference):
What do you guys think? @NSLS-II/blop-team Here is the context of my understanding of blop so far since I am still fairly new to the project: blop only needs to be able to change the values of certain devices (i.e. motors, temperature controllers, etc.) and read back the result (from detectors, motors, temperature controllers, etc.) in order to run its optimization. Bayesian optimization should not require any interaction with ophyd (or ophyd-async) devices within a single iteration of its algorithm. Using a |
In principle, every iteration of BO can be a scan. We could refactor the |
We need to test that blop can work with ophyd-async devices.
The text was updated successfully, but these errors were encountered: