Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTUEEPLUS-310 Change the favicons to .svg format #264

Open
homuch opened this issue Apr 3, 2024 · 0 comments
Open

NTUEEPLUS-310 Change the favicons to .svg format #264

homuch opened this issue Apr 3, 2024 · 0 comments

Comments

@homuch
Copy link
Collaborator

homuch commented Apr 3, 2024

In client\src\views\in\abroadSession\utilities\getFavicon.js, some favicons are using an outer source with .png format. Try to change them into a .svg format (They can be saved as files in the asset folder or just a pure <svg /> element). client\src\views\in\abroadSession\Page.js may also need to be modified to make them properly.
(Perhaps icon resources can be found here)
By the way, it's encouraged to add more favicon for other sites, replace <LinkIcon /> with a <CIcon /> or another .svg icon, or do anything that may make the page better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant