Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Missing header in test case #199

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

Lifann
Copy link
Collaborator

@Lifann Lifann commented Jul 30, 2024

Fixed std::scientific was undefined when compiling test cases.
gcc: 9.2.1
cuda: 12.3

Copy link

@Lifann Lifann requested a review from rhdong July 31, 2024 03:33
@rhdong
Copy link
Member

rhdong commented Aug 1, 2024

/blossom-ci

Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lifann Lifann force-pushed the tests-miss-header branch from 33405c5 to 25995c5 Compare August 8, 2024 13:28
@rhdong
Copy link
Member

rhdong commented Aug 9, 2024

/blossom-ci

1 similar comment
@jiashuy
Copy link
Collaborator

jiashuy commented Aug 9, 2024

/blossom-ci

@rhdong rhdong merged commit 4f38be5 into NVIDIA-Merlin:master Aug 9, 2024
2 checks passed
@Lifann Lifann deleted the tests-miss-header branch August 12, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants