Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos and GCC warning fixes #63

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Typos and GCC warning fixes #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
508c392
[Validation] fix vertex format check
GaelCathelin Jan 22, 2025
7fff734
Fix AllGraphics mask typo
GaelCathelin Jan 10, 2025
30fa13c
Fix GCC warnings
GaelCathelin Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/nvrhi/nvrhi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,7 +757,7 @@ namespace nvrhi
Pixel = 0x0010,
Amplification = 0x0040,
Mesh = 0x0080,
AllGraphics = 0x00FE,
AllGraphics = 0x00DF,

RayGeneration = 0x0100,
AnyHit = 0x0200,
Expand Down
3 changes: 2 additions & 1 deletion src/validation/validation-commandlist.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1263,6 +1263,7 @@ namespace nvrhi::validation
{
case Format::RG32_FLOAT:
case Format::RGB32_FLOAT:
case Format::RGBA32_FLOAT:
case Format::RG16_FLOAT:
case Format::RGBA16_FLOAT:
case Format::RG16_SNORM:
Expand All @@ -1278,7 +1279,7 @@ namespace nvrhi::validation
default: {
std::stringstream ss;
ss << "BLAS " << utils::DebugNameToString(as->getDesc().debugName) << " build geometry " << i
<< " has unsupported vertex format: " << utils::FormatToString(triangles.indexFormat);
<< " has unsupported vertex format: " << utils::FormatToString(triangles.vertexFormat);
error(ss.str());
return;
}
Expand Down
2 changes: 1 addition & 1 deletion src/vulkan/vulkan-device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ namespace nvrhi::vulkan
try {
m_Context.device.waitIdle();
}
catch (vk::DeviceLostError e)
catch (vk::DeviceLostError &e)
{
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion src/vulkan/vulkan-queue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ namespace nvrhi::vulkan
try {
m_Queue.submit(submitInfo);
}
catch (vk::DeviceLostError e)
catch (vk::DeviceLostError &e)
{
m_Context.messageCallback->message(MessageSeverity::Error, "Device Removed!");
}
Expand Down
Loading