Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argminmax operator #778

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Add argminmax operator #778

merged 1 commit into from
Oct 22, 2024

Conversation

tmartin-gh
Copy link
Collaborator

@tmartin-gh tmartin-gh commented Oct 22, 2024

No description provided.

@cliffburdick
Copy link
Collaborator

/build

Copy link
Collaborator

@cliffburdick cliffburdick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs unit tests and documentation

@cliffburdick
Copy link
Collaborator

@tylera-nvidia please look at this one and test the performance if you still have that data.

@tmartin-gh
Copy link
Collaborator Author

/build

@tmartin-gh
Copy link
Collaborator Author

Needs unit tests and documentation

Added unit tests.

@tmartin-gh
Copy link
Collaborator Author

/build

@tmartin-gh
Copy link
Collaborator Author

Needs unit tests and documentation

Added documentation for argminmax

@coveralls
Copy link

Coverage Status

coverage: 93.167% (+0.03%) from 93.14%
when pulling 60bad09 on tmartin-gh:tjm/issue_691
into 34978cf on NVIDIA:main.

@tmartin-gh tmartin-gh linked an issue Oct 22, 2024 that may be closed by this pull request
@tmartin-gh tmartin-gh merged commit b546ad0 into NVIDIA:main Oct 22, 2024
1 check passed
@tmartin-gh
Copy link
Collaborator Author

/build

@cliffburdick cliffburdick mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] add argminmax function
3 participants