Clean up internal column logic in _run_classifier_helper function
#457
Conversation
Signed-off-by: Sarah Yurick <[email protected]>
Signed-off-by: Sarah Yurick <[email protected]>
| if prob_col: | ||
| df[prob_col] = 0 |
There was a problem hiding this comment.
I wanted CrossFit to internally create the prob_col, but I was having trouble getting this to work. Specifically, I was able to get the entire classification pipeline to work, but then at the end prob_col would be dropped somewhere and not returned with the result.
There was a problem hiding this comment.
Thanks for making the PR. I like the changes, thanks for cleaning it up.
Would you mind creating a issue on crossfit (with a MRE), we can merge this PR and then fix it in crossfit.
There was a problem hiding this comment.
I have opened an issue here: rapidsai/crossfit#108. Please LMK if there is anything else I can clarify there. Thanks!
| if prob_col: | ||
| df[prob_col] = 0 |
There was a problem hiding this comment.
Thanks for making the PR. I like the changes, thanks for cleaning it up.
Would you mind creating a issue on crossfit (with a MRE), we can merge this PR and then fix it in crossfit.
sarahyurick
added
gpuci
Closes #425.