From 8f4828537ca537b928a598d5556904e91ac89554 Mon Sep 17 00:00:00 2001 From: Yunsong Wang Date: Wed, 13 Dec 2023 15:13:28 -0800 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Daniel Jünger <2955913+sleeepyjack@users.noreply.github.com> --- .../cuco/detail/open_addressing/open_addressing_ref_impl.cuh | 4 ++-- include/cuco/static_map_ref.cuh | 2 ++ include/cuco/static_set_ref.cuh | 2 ++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/include/cuco/detail/open_addressing/open_addressing_ref_impl.cuh b/include/cuco/detail/open_addressing/open_addressing_ref_impl.cuh index 2def9041d..1cebc79f6 100644 --- a/include/cuco/detail/open_addressing/open_addressing_ref_impl.cuh +++ b/include/cuco/detail/open_addressing/open_addressing_ref_impl.cuh @@ -279,7 +279,7 @@ class open_addressing_ref_impl { [[nodiscard]] __host__ __device__ constexpr iterator end() noexcept { return storage_ref_.end(); } /** - * @brief Makes a copy of the current device ref using non-owned memory + * @brief Makes a copy of the current device reference using non-owned memory. * * This function is intended to be used to create shared memory copies of small static data * structures, although global memory can be used as well. @@ -313,7 +313,7 @@ class open_addressing_ref_impl { } /** - * @brief Initializes the container storage using the threads in the group `tile`. + * @brief Initializes the container storage. * * @note This function synchronizes the group `tile`. * diff --git a/include/cuco/static_map_ref.cuh b/include/cuco/static_map_ref.cuh index 26b30a9fc..8640916de 100644 --- a/include/cuco/static_map_ref.cuh +++ b/include/cuco/static_map_ref.cuh @@ -203,6 +203,8 @@ class static_map_ref * This function is intended to be used to create shared memory copies of small static maps, * although global memory can be used as well. * + * @note This function synchronizes the group `tile`. + * * @tparam CG The type of the cooperative thread group * * @param tile The ooperative thread group used to copy the data structure diff --git a/include/cuco/static_set_ref.cuh b/include/cuco/static_set_ref.cuh index 76492c729..3408fed04 100644 --- a/include/cuco/static_set_ref.cuh +++ b/include/cuco/static_set_ref.cuh @@ -181,6 +181,8 @@ class static_set_ref * This function is intended to be used to create shared memory copies of small static sets, * although global memory can be used as well. * + * @note This function synchronizes the group `tile`. + * * @tparam CG The type of the cooperative thread group * * @param tile The ooperative thread group used to copy the data structure